my $pattern = $rtCount->makeRowHash( address => $data[1] ) or die "$!"; my $rhFound = $tCount->find($pattern) or die "$!";
becomes
my $rhFound = $tCount->findBy( address => $data[1] ) or die "$!";
Naturally, it's not in version 0.99 but will be available in 1.00. The implementation is fairly simple. There is no reason why a class can't mix the XS methods and plain Perl methods. So I've added the file lib/Triceps/Table.pm, added it to be imported in lib/Triceps.pm, and put the Perl method in there:
package Triceps::Table; use Carp; sub findBy # (self, fieldName => fieldValue, ...) { my $self = shift; my $row = $self->getRowType()->makeRowHash(@_) or Carp::confess "$!"; return $self->find($row); }
Carp::confess() is a better kind of die(), I'll will discuss it in more detail later. Fairly simple and straightforward. If you see something missing, you can also always extend Triceps in the same way.
However if you change the Triceps code directly like I did, you'll have an issue with the next Triceps release: it woudl overwrite your file and your change would be lost. This can be solved in one of two ways. The first way is to write me an e-mail, describe your new useful change, and send me a context diff with its code. If I like it, I'll include it into the Triceps code base.
The second way comes useful if you want to keep the change to yourself, or if you sent it to me and I didn't like it: just make your own wrapper of the Table class and add the new method there. Then use your class instead of Triceps::Table. For example:
package MyTable; our @ISA = qw(Triceps::Table); sub new # (class, unit, args of makeTable...) { my $class = shift; my $unit = shift; my $self = $unit->makeTable(@_); return undef unless defined $self; bless $self, $class; return $self; } sub myFindBy { ... } package main; ... my $tCount = MyTable->new( $hwunit, $ttCount, &Triceps::EM_CALL, "tCount") or die "$!";
That's also a simplest template: a modifying wrapper for one class.
No comments:
Post a Comment